Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context error in govultr test #239

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Mar 13, 2023

Description

Linting changes prompted a test failure here. Just remove the error handling like it was before updating to the new library.

Additionally, the codecov bot that was used before stopped working a while back so I think it's pertinent to remove the related actions for now. The implementation uses deprecated github features and will need to be addressed when re-adding the codecov automation.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper self-assigned this Mar 13, 2023
@optik-aper optik-aper added the bug Something isn't working label Mar 13, 2023
@optik-aper optik-aper merged commit 604570e into vultr:master Mar 13, 2023
@optik-aper optik-aper mentioned this pull request Mar 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant