Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource response functionality #240

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

mondragonfx
Copy link
Contributor

Description

PR for adding return response for vultr resources to govultr.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@happytreees happytreees requested review from christhemorse, happytreees and optik-aper and removed request for optik-aper March 15, 2023 14:22
happytreees
happytreees previously approved these changes Mar 15, 2023
Copy link
Contributor

@happytreees happytreees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces breaking changes to the package for any endusers

@happytreees happytreees self-requested a review March 15, 2023 14:39
@happytreees happytreees dismissed their stale review March 15, 2023 14:39

re-review

Copy link
Contributor

@happytreees happytreees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@christhemorse christhemorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after recent changes. Nothing else has jumped out at me and the approach for passing along the API json response should help enable a json feature for vultr-cli and other utilities, and give folks using the library more flexibility to use that data if they need it. Approved.

@happytreees happytreees merged commit 4a0b177 into vultr:master Mar 15, 2023
@optik-aper optik-aper added the enhancement New feature or request label Mar 20, 2023
@optik-aper optik-aper mentioned this pull request Mar 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants