feat[venom]: implement mem2var and sccp passes
#3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve venom performance
Comment on lines
454
to
461
|
|
||
| if experimental_codegen: | ||
| with pytest.raises(StaticAssertionException): | ||
| get_contract(code) | ||
| else: | ||
| c = get_contract(code) | ||
| with tx_failed(): | ||
| c.foo() |
There was a problem hiding this comment.
we should change the code as above so the runtime check is appropriately checked
Comment on lines
77
to
92
| def test_exponent_negative_power(get_contract, tx_failed, base, experimental_codegen): | ||
| # #2985 | ||
| code = f""" | ||
| @external | ||
| def bar() -> int16: | ||
| x: int16 = -2 | ||
| return {base} ** x | ||
| """ | ||
| c = get_contract(code) | ||
| # known bug: 2985 | ||
| with tx_failed(): | ||
| c.bar() | ||
| if experimental_codegen: | ||
| with pytest.raises(StaticAssertionException): | ||
| get_contract(code) | ||
| else: | ||
| c = get_contract(code) | ||
| # known bug: 2985 | ||
| with tx_failed(): | ||
| c.bar() |
| typ: VyperType, | ||
| is_internal: bool, | ||
| is_mutable: bool = True, | ||
| internal_function=False, |
There was a problem hiding this comment.
i added this, but i'm not a huge fan of this. it's fine for now though
vyper/venom/passes/simplify_cfg.py
Outdated
| @@ -79,4 +86,9 @@ def _collapse_chained_blocks(self, entry: IRBasicBlock): | |||
| def _run_pass(self, ctx: IRFunction, entry: IRBasicBlock) -> None: | |||
| self.ctx = ctx | |||
|
|
|||
| self._collapse_chained_blocks(entry) | |||
| for _ in range(len(ctx.basic_blocks)): # essentialy `while True` | |||
There was a problem hiding this comment.
Suggested change
| for _ in range(len(ctx.basic_blocks)): # essentialy `while True` | |
| for _ in range(len(ctx.basic_blocks)): # essentially `while True` |
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
This commit adds two additional optimization passes to the Venom pipeline, `mem2var` and `Sparse Conditional Constant Propagation`. The `mem2var` pass has the purpose of promoting some of the memory accesses that the frontend emits to Venom variables, optimizing out memory reads and writes. It is analogous to the `mem2reg` pass in LLVM. Right now it only applies promotions conservatively, but is the basis for more advanced memory optimizations in the future. To facilitate the implementation of `mem2var` this commit additionally modifies the original IR emitter to emit "abstract" memory locations (i.e. "allocas") instead of hard-coded pointers if the venom pipeline is enabled. A small amount of refactoring was done to the memory allocator to enable this switch to be implemented cleanly. The `sccp` pass is responsible for evaluating and propagating constants in the code, eliminating conditional branches and performing dead code elimination in the process. It is a linear `O(2n)` pass, based on the classical algorithm by Wegman and Zadeck. References: https://dl.acm.org/doi/pdf/10.1145/103135.103136 --------- Co-authored-by: Charles Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented two additional Venom optimization passes: Mem2Var and SCCP.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture