When a job fails it tries to reject it twice.

[phalouvas]

When a job fails in Consumer.php the override of function markJobAsFailedIfWillExceedMaxAttempts causes job to try to reject twice resulting failure on the consumer, due to false tag message.

This occurs only if the job running throw exception for some reason. Above fix remove that function. After that it works as expected.

[vyuldashev]

Try v10.2.0

[phalouvas]

Hello, I transferred the core Joomla data but there is problem with the users. You have many users in the source site with no username. That is not allowed in the new Joomla version. Can you please check how many users like this you have in the source site? Kind regards, Panayiotis Halouvas From: Vladimir Yuldashev <[email protected]> Sent: Friday, April 24, 2020 10:09 PM To: vyuldashev/laravel-queue-rabbitmq <[email protected]> Cc: Panayiotis Halouvas <[email protected]>; Author <[email protected]> Subject: Re: [vyuldashev/laravel-queue-rabbitmq] When a job fails it tries to reject it twice. (#322) Try v10.2.0 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#322 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLENO4UXRLQLB2RR26VTGDROHPT3ANCNFSM4LGFDINQ> . <https://github.com/notifications/beacon/ABLENO32UPA6DX5NFTBFWYDROHPT3A5CNFSM4LGFDIN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOETUB63A.gif>

[adm-bome]

@vyuldashev @phalouvas I think this can be closed

[phalouvas]

Did not manage to test so far, but you can close it since it passed all your tests. If I find something in the future, will let you know.

[adm-bome]

As of v10.2.0 the library strategy is different. I think this issue is resolved.

May you still find yourself having this issue, dont hesitate to mention this in this issue.

[phalouvas]

Unfortunately problem still exists with new version 10.2.

if you start the consumer with php artisan rabbitmq:consume --queue=default --tries=3
and a job throws exception, it does not rerun. It gives this: https://1drv.ms/u/s!AljvtJPILTC7gZ_LM-EJmK5XartGhQg?e=C0K38m

[adm-bome]

Your right ;)
Overlooked with the latest refactor. The method has no meaning anymore.

Further testing is needed.

[adm-bome]

I have one question, when removing this method, what happens with the message in RabbitMQ?
Because an error occurs, the message must not be lost within the process.
It must either be released or deleted.

As the message can't be handled twice: Where did it go or what happened to the message?

@vyuldashev
Was there a special case why these extra lines were added into this method?

[phalouvas]

@adm-bome if I remember correctly the job is removed. Not 100% sure though. Need to test again to see. In any case the whole thing needs revision.

That goes for adding delay before rerun etc

[adm-bome]

I will look into the consumer part, somewere in the next 3 days. Some rework must be done.

The consumer is an extra addition to the queue driver part. Without the consumer the lib still works. ;)

[adm-bome]

Method can be removed. The code after parent call does conflict with the consumer/worker code and the strategy to reject or release the Job message.

The message is released into the queue