Add publicKeyMultibase definition. #103
Conversation
msporny
force-pushed
the
msporny-did-core-issue-707
branch
from
1fda444 to
8c5ef90
Compare
msporny
changed the base branch from
master
to
dependabot/npm_and_yarn/elliptic-6.5.4
msporny
changed the base branch from
dependabot/npm_and_yarn/elliptic-6.5.4
to
master
Yeah, we do. I'm deep in something else right now, so change request would be good, if not, I may get back around to it. |
+1, this would address questions raised e.g. in w3c/did#731 (comment) and w3c/did#707 (comment). |
Co-authored-by: Dave Longley <[email protected]>
| version of a public key. Each key type definition is expected to specify | ||
| one or more required encoding bases. Specifying only a single encoding | ||
| base per key type is preferable as it reduces the burden to reach broad | ||
| interoperability. |
There was a problem hiding this comment.
I'm a bit worried that there's quite a bit of tribal knowledge in this. For example, how do I encode a nist p256 key here? How do I specify the encoding. If this is meant to be documentation to be "hey this thing exists" then this is fine, but if we're actually expecting people to build interoperable software against this definition they'll undoubtedly get stuck.
For specific action items I'd like to see, I'd like to see us reference how encoding works by directly referencing multibase and additionally reference how multicodec table is used and finally include how serialization of the bytes should work as well.
I'm all for this additional change, but I think this is a bit too light to actually be something that someone without prior knowledge could implement.
There was a problem hiding this comment.
yes, probably also a good idea to always recommend compressed form keys.
There was a problem hiding this comment.
see also multiformats/multicodec#210
There was a problem hiding this comment.
I have applied suggestions from @kdenhartog, @peacekeeper, and @OR13 in 924eea4.
If you want further changes, please suggest concrete spec text -- it's hard to read minds and then write spec text. :P
This PR partially addresses an issue in w3c/did#707 by registering
publicKeyMultibase, which is needed before registeringpublicKeyMultibasein https://github.com/w3c/did-spec-registries.