Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualKeyboard spec feedback #314

Closed
yoavweiss opened this issue Jul 7, 2021 · 2 comments
Closed

VirtualKeyboard spec feedback #314

yoavweiss opened this issue Jul 7, 2021 · 2 comments

Comments

@yoavweiss
Copy link

Looking at https://w3c.github.io/editing/docs/virtualkeyboard/, there are a few points that can be made clearer:

  • In section 3, "If the browsing context's active window" is inaccurate. It'd be better IMO to replace it with "this's relevant global" while asserting that it's indeed a Window (which it should be, as the method is only exposed on a Window).
  • I'm assuming that step 5 in both show() and hide() should be run in parallel, and the event doesn't fire synchronously. You should make that explicit. Depending if step 4 takes time, you may also want to run it in parallel as well.
  • overlaysContent is missing a setter that would impact processing of the virtual keyboard and its interaction with the content. As is, it's really unclear what it's supposed to be doing. (e.g. I'm assuming you didn't mean for it to impact viewport changes that are unrelated to virtual keyboards)
  • boundingRect should have a clear getter that defines what the returned values are.

/cc @gked

snianu added a commit to snianu/editing that referenced this issue Jul 23, 2021
@snianu
Copy link
Contributor

snianu commented Jul 23, 2021

@yoavweiss Addressed all your comments here

snianu added a commit to snianu/editing that referenced this issue Jul 27, 2021
@snianu
Copy link
Contributor

snianu commented Jul 29, 2021

This issue has been addressed in the linked PR.

@snianu snianu closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants