-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirtualKeyboard spec feedback #314
Comments
snianu
added a commit
to snianu/editing
that referenced
this issue
Jul 23, 2021
@yoavweiss Addressed all your comments here |
snianu
added a commit
to snianu/editing
that referenced
this issue
Jul 27, 2021
This issue has been addressed in the linked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looking at https://w3c.github.io/editing/docs/virtualkeyboard/, there are a few points that can be made clearer:
show()
andhide()
should be run in parallel, and the event doesn't fire synchronously. You should make that explicit. Depending if step 4 takes time, you may also want to run it in parallel as well.overlaysContent
is missing a setter that would impact processing of the virtual keyboard and its interaction with the content. As is, it's really unclear what it's supposed to be doing. (e.g. I'm assuming you didn't mean for it to impact viewport changes that are unrelated to virtual keyboards)boundingRect
should have a clear getter that defines what the returned values are./cc @gked
The text was updated successfully, but these errors were encountered: