Trim input parameters to HTML hooks #436
Conversation
These algorithms do not need as many parameters as they are currently declared to take. This removes the redundant parameters so that HTML can stop supplying them, which helps with whatwg/html#1130.
|
@domenic still want to merge this? I'm happy to do it. |
index.src.html
Outdated
| @@ -1348,13 +1348,12 @@ <h4 id="should-block-inline" algorithm> | |||
| </ol> | |||
|
|
|||
| <h4 id="should-block-navigation-request" algorithm> | |||
There was a problem hiding this comment.
We should also export this and the one below, even though HTML doesn't strictly need that.
There was a problem hiding this comment.
It's not clear how to do that since there's no <dfn>...
There was a problem hiding this comment.
You can put them directly on the h4 as I understand it.
There was a problem hiding this comment.
I've tested and that will indeed add a data-export attribute, but there's no data-dfn-type attribute, so I'm pretty sure they still won't show up in any linking databases. (Per https://tabatkins.github.io/bikeshed/#dfn-contract .)
There was a problem hiding this comment.
You can also check that they don't show up in https://w3c.github.io/webappsec-csp/#index-defined-here
There was a problem hiding this comment.
I guess per https://tabatkins.github.io/bikeshed/#dfn-contract it would also require dfn? Is this using the algorithm attribute incorrectly then? This document is such a mess...
There was a problem hiding this comment.
(I care as I also need to update this for Fetch.)
There was a problem hiding this comment.
Ah yeah, adding dfn seems to help. I'll do that, I guess...
|
Yes, merging this would be great! |
Follows w3c/webappsec-csp#436. Helps with #1130.
Follows w3c/webappsec-csp#436. Helps with #1130.
These algorithms do not need as many parameters as they are currently declared to take. This removes the redundant parameters so that HTML can stop supplying them, which helps with whatwg/html#1130.
Preview | Diff