Resource hint: check directives explicitly #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the previous wording was a no-op. Instead of calling the pre-request check, checking the resource list for the directives that have that as a value. Closes w3c#633
noamr
requested review from
mikewest and
antosart
and removed request for
mikewest
antosart
reviewed
Jan 16, 2024
|
|
||
| then continue. | ||
|
|
||
| 1. Assert: |directive|'s <a for="directive">value</a> is a <a>source list</a>. |
There was a problem hiding this comment.
I guess this is not always true. For script-src there can be nonces and hashes and keywords.
|
|
||
| then continue. | ||
|
|
||
| 1. Assert: |directive|'s <a for="directive">value</a> is a <a>source list</a>. |
There was a problem hiding this comment.
Should these and subsequent items in this list be incremented? Right now, they’re all numbered '1.' Was that intentional?
There was a problem hiding this comment.
FWIW, I think that's usually intentional so you don't have to renumber when you add or remove steps. (The output won't contain these numbers.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the previous wording was a no-op.
Instead of calling the pre-request check, checking the resource list for the directives that have that as a value.
Closes #633