Set up ReceiveStream with proper algorithms #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define pullAlgorithm and cancelAlgorithm, and set up ReceiveStream with them. This relies on whatwg/streams#1130. Fixes #185.
|
@ricea, can you take a look? |
domenic
suggested changes
Jun 28, 2021
ricea
reviewed
Jun 29, 2021
| 1. If |hasReceivedFIN| is true: | ||
| 1. [=set/Remove=] |stream| from |transport|'s [=[[ReceiveStreams]]=]. | ||
| 1. [=ReadableStream/Close=] |stream|. | ||
| 1. [=Resolve=] |promise| with undefined. |
There was a problem hiding this comment.
It looks like if a RESET_STREAM signal comes from the server, this promise will never be resolved. It doesn't seem to be observable, but it feels untidy to me.
There was a problem hiding this comment.
Added a step and a note. We need to reject the promise with a proper error object, so I'd like to leave it as is.
yutakahirano
commented
Jul 1, 2021
|
The Streams spec change has been merged and within 24 hours should show up in cross-linking databases. One thing that changed is we used "enqueue" instead of "enqueue bytes". |
|
Thank you! I updated the PR. PTAL again. |
domenic
reviewed
Jul 16, 2021
domenic
added a commit
to whatwg/streams
that referenced
this pull request
Jul 16, 2021
domenic
approved these changes
Jul 23, 2021
|
@ricea, can you take a look again? |
ricea
approved these changes
Jul 27, 2021
|
lgtm |
|
Thank you! |
github-actions bot
added a commit
that referenced
this pull request
Jul 30, 2021
SHA: d1be624 Reason: push, by @yutakahirano Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define pullAlgorithm and cancelAlgorithm, and set up ReceiveStream
with them.
This relies on whatwg/streams#1130.
Fixes #185.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jul 29, 2021, 2:42 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.