Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darwin] Add support for Request/Response streaming #2219

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Dec 19, 2022

No description provided.

@stffabi stffabi requested a review from leaanthony December 19, 2022 08:01
@stffabi stffabi force-pushed the feature/macos-response-streaming branch 2 times, most recently from a5dca50 to 9ad5b33 Compare December 19, 2022 19:10
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a question on the docs update 😄

@@ -258,11 +258,11 @@ Not all features of an `http.Request` are currently supported, please see the fo
| DELETE | ✅ | ✅ | ✅ [^1] |
| Request Headers | ✅ | ✅ | ✅ [^1] |
| Request Body | ✅ | ✅ | ❌ |
| Request Body Streaming | | | ❌ |
| Request Body Streaming | | | ❌ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was Windows updated as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already supported that on Windows for quite some time. Just the docs wasn't updated 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Streaming for Windows will come soon 😄

@stffabi stffabi force-pushed the feature/macos-response-streaming branch from 9ad5b33 to 6890209 Compare December 20, 2022 12:18
@stffabi stffabi merged commit a312c0f into wailsapp:master Dec 20, 2022
@stffabi stffabi deleted the feature/macos-response-streaming branch December 20, 2022 12:44
@stffabi
Copy link
Collaborator Author

stffabi commented Dec 20, 2022

Thanks for approving 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants