refactor: validate protobuffer for store #841

richard-ramos · 2023-10-26T20:18:27Z

Description

Validates the content of the protobuffers used in store protocol

status-im-auto · 2023-10-26T20:21:00Z

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7b6ac60`	#1	2023-10-26 20:21:00	~2 min	`nix-flake`	📄`log`
✖️	`7b6ac60`	#1	2023-10-26 20:21:00	~2 min	`tests`	📄`log`
✔️	`7b6ac60`	#1	2023-10-26 20:21:09	~2 min	`linux`	📦`deb`
✖️	`7b6ac60`	#1	2023-10-26 20:21:42	~2 min	`tests`	📄`log`
✔️	`7b6ac60`	#1	2023-10-26 20:23:05	~4 min	`android`	📦`tgz`
✔️	`7b6ac60`	#1	2023-10-26 20:23:17	~4 min	`ios`	📦`tgz`

✔️	`be98893`	#2	2023-10-26 20:43:14	~2 min	`nix-flake`	📄`log`
✔️	`be98893`	#2	2023-10-26 20:43:20	~2 min	`linux`	📦`deb`
✔️	`be98893`	#2	2023-10-26 20:44:44	~3 min	`tests`	📄`log`
✔️	`be98893`	#2	2023-10-26 20:44:45	~3 min	`tests`	📄`log`
✔️	`be98893`	#2	2023-10-26 20:44:55	~4 min	`android`	📦`tgz`
✔️	`be98893`	#2	2023-10-26 20:45:00	~4 min	`ios`	📦`tgz`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`0287ed8`	#3	2023-10-30 16:41:08	~1 min	`tests`	📄`log`
✔️	`0287ed8`	#3	2023-10-30 16:41:12	~1 min	`linux`	📦`deb`
✖️	`0287ed8`	#3	2023-10-30 16:41:20	~1 min	`tests`	📄`log`
✔️	`0287ed8`	#3	2023-10-30 16:41:48	~1 min	`nix-flake`	📄`log`
✔️	`0287ed8`	#3	2023-10-30 16:43:28	~3 min	`android`	📦`tgz`

✔️	`8e23de6`	#4	2023-10-30 16:44:37	~1 min	`linux`	📦`deb`
✔️	`8e23de6`	#4	2023-10-30 16:45:32	~2 min	`nix-flake`	📄`log`
✔️	`8e23de6`	#4	2023-10-30 16:46:56	~3 min	`tests`	📄`log`
✔️	`8e23de6`	#4	2023-10-30 16:47:03	~3 min	`tests`	📄`log`
✔️	`8e23de6`	#4	2023-10-30 16:47:33	~4 min	`android`	📦`tgz`
✔️	`8e23de6`	#4	2023-10-30 16:55:16	~11 min	`ios`	📦`tgz`

waku/v2/protocol/store/pb/validation.go

waku/v2/protocol/store/waku_store_protocol.go

chaitanyaprem

LGTM
Few comments.

richard-ramos requested review from chaitanyaprem and harsh-98 October 26, 2023 20:18

github-actions bot assigned richard-ramos Oct 26, 2023

richard-ramos force-pushed the feat/protobuf-store-validation branch from 7b6ac60 to be98893 Compare October 26, 2023 20:40

chaitanyaprem reviewed Oct 27, 2023

View reviewed changes

chaitanyaprem approved these changes Oct 27, 2023

View reviewed changes

richard-ramos force-pushed the feat/protobuf-store-validation branch from be98893 to 0287ed8 Compare October 30, 2023 16:39

refactor: validate protobuffer for store

8e23de6

richard-ramos force-pushed the feat/protobuf-store-validation branch from 0287ed8 to 8e23de6 Compare October 30, 2023 16:43

richard-ramos merged commit 4584bb4 into master Oct 30, 2023

richard-ramos deleted the feat/protobuf-store-validation branch October 30, 2023 16:55