Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: gowaku store fixes #104

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: gowaku store fixes #104

merged 1 commit into from
Feb 5, 2025

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Feb 4, 2025 •
edited
Loading

PR Details

  • Go-waku still uses the old hashing, this PR addresses that cc @gabrielmer
  • Retesting some old bugs that have been fixed in the meantime and unskipped tests
  • Small adjustments to increase consistency

@fbarbu15 fbarbu15 marked this pull request as ready for review February 5, 2025 06:59
gabrielmer
gabrielmer approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks so much! And apologies for the mess caused 🙃

@fbarbu15 fbarbu15 merged commit c217ea0 into master Feb 5, 2025
26 of 39 checks passed
@fbarbu15 fbarbu15 deleted the chore/gowaku-store-fixes branch February 5, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AYAHASSAN287 AYAHASSAN287 AYAHASSAN287 approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbarbu15 @AYAHASSAN287 @gabrielmer