CI_RUNNERS #88
Merged
CI_RUNNERS #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarbu15
reviewed
Dec 27, 2024
.github/workflows/test_common.yml
Outdated
| @@ -35,6 +35,12 @@ jobs: | |||
|
|
|||
| tests: | |||
| name: tests | |||
| strategy: | |||
| matrix: | |||
| shard: [ 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23, | |||
There was a problem hiding this comment.
this is overkill :)
I think we should use a max of 16 shards
Anyhow we would need to unskip RLN tests which need to run on the same shard and those tests will probably take more than any other shard, and the report needs to wait for them to finish.
fbarbu15
requested changes
Dec 31, 2024
fix: add multiple machines fix: prevent fail fast checkout on smoke_tests tag (#96) * checkout on smoke_tests tag * MOdify pytest command * Update README.md Add steps on how to use new tag for PR tests in readme file Remove multiple skips Revert changes in test_rln file
Comments added in workflow , skips removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR contains changes in CI job to do the following :
1- Using 16 shards to execute 387 tests in time <16 mins
2- Dividing tests between 3 machines [test_rln.py - test_cursor_manymsgs.py - rest of tests ]
3- Aggregate all reports into 1 report
Issues reported: