opentelemetry plugin #178
opentelemetry plugin #178
Conversation
pom.xml
Outdated
| @@ -52,6 +52,7 @@ | |||
| <module>tasks/terraform</module> | |||
| <module>tasks/xml</module> | |||
| <module>tasks/zoom</module> | |||
| <module>tasks/opentelemetry</module> | |||
There was a problem hiding this comment.
Should be in /plugins/runtime/opentelementry, IMO. First of its kind :-)
brig
force-pushed
the
brig/opentelemetry-plugin
branch
from
c984bf8 to
32f4aba
Compare
tasks/opentelemetry/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-annotations</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.dataformat</groupId> | ||
| <artifactId>jackson-dataformat-yaml</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
jackson deps can be provided scope
There was a problem hiding this comment.
We should mention somewhere in the documentation what dependencies and how can be used in plugins :)
There was a problem hiding this comment.
We kind of do mention it but I agree we need to give a more explicit here-exactly-what's-provided .
There was a problem hiding this comment.
Oh, right, I didn't notice :)
There was a problem hiding this comment.
we need maven plugin for concord plugins :)
so maven plugin can verify that everything is ok with plugin...
| import javax.inject.Named; | ||
|
|
||
| @Named | ||
| public class OpentelemetryModule implements com.google.inject.Module { |
There was a problem hiding this comment.
| public class OpentelemetryModule implements com.google.inject.Module { | |
| public class OpentelemetryModule implements Module { |
|
Let's add a README.md with the usage instructions. We can link to https://www.jaegertracing.io/docs/1.62/getting-started/#all-in-one or w/e for a local collector. |
plugin configuration is set as the default task variables for the
opentelemetrytask