Updated to wasm-pack 0.10.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pauan
requested changes
Jul 3, 2021
example/package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "build": "rimraf dist/js && rollup --config" | |||
| }, | |||
| "devDependencies": { | |||
| "@wasm-tool/rollup-plugin-rust": "^1.0.0", | |||
| "@wasm-tool/rollup-plugin-rust": "file:..", | |||
There was a problem hiding this comment.
I prefer for the example to be self-contained, so it will work even if the user copy-pastes it into their own project.
There was a problem hiding this comment.
(Also note that if you want to test locally, you can use yarn link to override @wasm-tool/rollup-plugin-rust with the local version)
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "@wasm-tool/rollup-plugin-rust", | |||
| "author": "Pauan <[email protected]>", | |||
| "description": "Rollup plugin for bundling and importing Rust crates.", | |||
| "version": "1.0.6", | |||
| "version": "1.0.7", | |||
There was a problem hiding this comment.
Please don't bump the version, I do that right before releasing.
simlay
force-pushed
the
update-to-wasm-pack-0.10.0
branch
from
bc8532d to
3ccb7ce
Compare
|
Thanks! |
|
@Pauan Would you be up to publish a new release to npmjs? |
|
@simlay Yeah, sorry for the delay, I need to update my npm first, since yarn isn't allowing me to publish. |
|
I published version 1.0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves security issue from rustwasm/wasm-pack#958.
I tested this in the examples directory (and left the relative path file dependency).