This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Test allSettled to allow commenting #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Watermelon AI SummaryThis Pull Request addresses a bug where the system is expected to wait for all associated functions to complete before producing an output, which might be related to comment functionality not working as intended when values return prematurely or as empty. It involves a bug fix to ensure proper sequencing and completion of tasks. GitHub PRs
watermelon is an open repo and Watermelon will serve it for free. |
EstebanDalelR
commented
Jan 24, 2024
| @@ -437,7 +437,7 @@ export async function POST(request: Request) { | |||
| repoName: repo, | |||
| }); | |||
| textToWrite += randomText(); | |||
| Promise.all([ | |||
| Promise.allSettled([ | |||
| // Detect console.logs and its equivalent in other languages | |||
| CodeComments | |||
There was a problem hiding this comment.
Maybe this value is falsy?
9 tasks
baristaGeek
approved these changes
Jan 24, 2024
Merged
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This expects all functions to end before returning
Type of change
Notes
Possibly the values are returning as empty?
Acceptance