Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys to reporting API feature #2601

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 3, 2025

This brings many more keys under the umbrella of the reporting API feature.

I lightly revised the description to match how handle other features, by naming the entry points.

The discussion on #2397 notwithstanding, the description of the feature included the whole kitchen sink, so I moved all the keys for the reporting API here, including the CSP-related keys.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 3, 2025
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on the description. Apart from that, I agree with adding these new keys to the feature. It seems like the Reporting API happened in pretty much one go, with no later additions. I don't see a need to split this up further.

@captainbrosset captainbrosset merged commit 8550757 into web-platform-dx:main Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants