-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ::scroll-button feature #2653
base: main
Are you sure you want to change the base?
Conversation
Hi @flackr, this is a question for each of your recent PRs: am I correct in understanding that these are all proposed features that are not yet shipping in any browsers? They seem to reference browser compat data and caniuse entries that don't exist. (We're still working out a process for what we've been calling "early" features. I'm betting these are likely to become important test cases.) |
I believe this is part of a larger feature aimed at enabling CSS-only carousel widgets, and I think there's an implementation in Chromium behind a flag. |
It is a set of independent features, but yes, they are part of a larger goal to make it easy to author pure CSS carousel experiences: https://github.com/w3c/csswg-drafts/blob/main/css-overflow-5/carousel-explainer.md There is an implementation in chromium and I2S's have been sent for these features:
What do we need to do to add these entries? |
The BCD entries (aka BCD keys) need to be added to the browser-compat-data project first. For this to happen, there needs to be an implementation of the feature in at least one browser, which you said there was, in Chromium. In theory, the BCD Collector should even detect the new feature and create the new keys for you automatically (provided the implementation actually ships enabled with a given milestone of Chromium). If this early feature doesn't yet have an enabled-by-default implementation, then we can still create yaml files for it here, and just omit the |
features/scroll-buttons.yml
Outdated
status: | ||
compute_from: css.selectors.scroll-button | ||
compat_features: | ||
- css.selectors.scroll-button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove all of this if the feature isn't yet covered by BCD.
If the implementation of this feature is shipping enabled then let's pause this PR, add the corresponding BCD keys (or check if the BCD collector can do it automatically), and then add the correct BCD key(s) here.
If not (and the chromestatus entry seems to say this isn't yet enabled), then let's leave this out for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've removed these entries for now. I will readd after it is enabled by default and the BCD collector adds the keys.
df76b90
to
f64e248
Compare
f64e248
to
58dc053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me as is. Would be good for @ddbeck to take another look as well since we don't yet a lot of early features like this and I know we have a goal this year of making it easier to create by then and modify them over time as spec changes happen.
No description provided.