Skip to content

Commit

Permalink
Remove unused 'scripts' parameter in WPT test generation script.
Browse files Browse the repository at this point in the history
This parameter wasn't used by any test definitions.

Change-Id: Ib7dd1deec5f87eacc5fad90bbbcfd94605d14e48
Bug: 1409873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209168
Reviewed-by: Aaron Krajeski <[email protected]>
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1100036}
  • Loading branch information
graveljp authored and pull[bot] committed Sep 19, 2023
1 parent 059a2e8 commit 1428420
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
5 changes: 0 additions & 5 deletions html/canvas/tools/gentestutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,6 @@ def _generate_test(test: Mapping[str, str], templates: Mapping[str, str],
timeout_js = ('// META: timeout=%s\n' % test['timeout']
if 'timeout' in test else '')

scripts = ''
for s in test.get('scripts', []):
scripts += '<script src="%s"></script>\n' % (s)

images = ''
for src in test.get('images', []):
img_id = src.split('/')[-1]
Expand Down Expand Up @@ -297,7 +293,6 @@ def _generate_test(test: Mapping[str, str], templates: Mapping[str, str],
'height': height,
'expected': expectation_html,
'code': code,
'scripts': scripts,
'fallback': fallback,
'attributes': attributes,
'context_args': context_args
Expand Down
5 changes: 0 additions & 5 deletions html/canvas/tools/gentestutilsunion.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,6 @@ def _generate_test(test: Mapping[str, str], templates: Mapping[str, str],
timeout_js = ('// META: timeout=%s\n' % test['timeout']
if 'timeout' in test else '')

scripts = ''
for s in test.get('scripts', []):
scripts += '<script src="%s"></script>\n' % (s)

images = ''
for src in test.get('images', []):
img_id = src.split('/')[-1]
Expand Down Expand Up @@ -324,7 +320,6 @@ def _generate_test(test: Mapping[str, str], templates: Mapping[str, str],
'height': height,
'expected': expectation_html,
'code': code_canvas,
'scripts': scripts,
'fallback': fallback,
'attributes': attributes,
'context_args': context_args
Expand Down
2 changes: 1 addition & 1 deletion html/canvas/tools/templates-new.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ w3ccanvas: |
}%(attributes)s);
</script>
%(scripts)s%(images)s
%(images)s
2 changes: 1 addition & 1 deletion html/canvas/tools/templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ w3ccanvas: |
}%(attributes)s);
</script>
%(scripts)s%(images)s
%(images)s

0 comments on commit 1428420

Please sign in to comment.