Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Web APIs in ShadowRealms. #32800

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Add tests for Web APIs in ShadowRealms. #32800

merged 1 commit into from
Feb 10, 2022

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 10, 2022

caitp
caitp approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@caitp caitp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as the dependencies match up with the ones used in non-SR idl tests, so nothing should be missing.

@caitp caitp merged commit 0e5b126 into master Feb 10, 2022
@caitp caitp deleted the shadowrealm-idl branch February 10, 2022 16:15
mattwoodrow pushed a commit to mattwoodrow/wpt that referenced this pull request Feb 15, 2022
@Ms2ger @mattwoodrow
Add tests for Web APIs in ShadowRealms. (web-platform-tests#32800)
db03d69 
Ref. tc39/proposal-shadowrealm#331.
DanielRyanSmith pushed a commit to DanielRyanSmith/wpt that referenced this pull request Feb 28, 2022
@Ms2ger @DanielRyanSmith
Add tests for Web APIs in ShadowRealms. (web-platform-tests#32800)
d758340 
Ref. tc39/proposal-shadowrealm#331.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caitp caitp caitp approved these changes

@annevk annevk Awaiting requested review from annevk

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@GPHemsley GPHemsley Awaiting requested review from GPHemsley

@igrigorik igrigorik Awaiting requested review from igrigorik

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@mikewest mikewest Awaiting requested review from mikewest

@plehegar plehegar Awaiting requested review from plehegar

@ricea ricea Awaiting requested review from ricea

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

@wanderview wanderview Awaiting requested review from wanderview

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@foolip foolip

Labels
compression encoding hr-time html performance-timeline streams url user-timing wg-webperf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ms2ger @caitp @foolip @wpt-pr-bot