-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebsocketProvider improvements #2855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractSocketProvider.js 169 line:
this.removeAllListeners();
this line removes all app defined provider listeners, so we can't receive 'connect', 'reconnected', 'error' events any more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed import isFunction in AbstractSubscription so on line 167, 180 undefined exception
All other seems fine. I hope this PR merged. I need it very much |
@boomfly Yes, I'll fix all of these. I'm currently testing the reconnecting of the socket connection with different edge cases etc. I will tag you for a final review later:) |
…vent handling updated
packages/web3-providers/lib/providers/AbstractSocketProvider.js
Outdated
Show resolved
Hide resolved
…tionTest updated.
….js into fix/websocket-reconnecting
Description
Fixes #2711 #2851
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct