-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.3.2 #3868
Merged
Merged
v1.3.2 #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.x: Fix EIP-1193 provider subscriptions
spacesailor24
previously approved these changes
Jan 21, 2021
The base branch was changed.
Replicating the steps mentioned in previous releases As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.
(This list will be actively edited)
Synthetix tests failed with a Contract: Exchange Rates
when integrating with modern contracts
✓ only expected functions should be mutative
constructor
✓ should set constructor params on deployment (79ms)
✓ two different currencies in same array should mean that the second one overrides (464ms)
✓ should revert when number of currency keys > new rates length on create (117ms)
✓ should limit to 32 bytes if currency key > 32 bytes on create (108ms)
✓ shouldn't be able to set exchange rate to 0 on create (93ms)
<--- Last few GCs --->
[22201:0x3627ef0] 928541 ms: Scavenge 1351.4 (1402.5) -> 1350.4 (1402.5) MB, 2.7 / 0.0 ms (average mu = 0.226, current mu = 0.156) allocation failure
[22201:0x3627ef0] 928550 ms: Scavenge 1357.5 (1408.8) -> 1356.5 (1408.8) MB, 2.7 / 0.0 ms (average mu = 0.226, current mu = 0.156) allocation failure
[22201:0x3627ef0] 928558 ms: Scavenge 1362.4 (1413.8) -> 1361.5 (1413.8) MB, 2.6 / 0.0 ms (average mu = 0.226, current mu = 0.156) allocation failure
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x39e1c391e6e9 <JSObject>
0: builtin exit frame: concat(this=0x1bfb37d97741 <JSArray[80704]>,0x10a7acd825a9 <JSArray[32]>,0x1bfb37d97741 <JSArray[80704]>)
1: MSTORE(aka MSTORE) [0x1ff57a306c59] [/home/anon/tmp/synthetix/node_modules/@nomiclabs/ethereumjs-vm/dist/evm/opFns.js:~445] [pc=0x38452532d2c8](this=0x358adc6822b1 <null>,runState=0x0e1bdff62131 <Object map = 0x3160dbc8a89>)
2: runStep [0x3e8f1207ff91] ...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8fa090 node::Abort() [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
2: 0x8fa0dc [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
3: 0xb0052e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
4: 0xb00764 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
5: 0xef4c72 [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
6: 0xef4d78 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
7: 0xf00e52 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
8: 0xf01784 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
9: 0xf043f1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
10: 0xecd4e6 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
11: 0xecdd6a v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
12: 0xeda751 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
13: 0xedaa4c v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
14: 0xe93e81 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
15: 0xb8fcc9 [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
16: 0xb993c8 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [/home/anon/.nvm/versions/node/v10.19.0/bin/node]
17: 0x38451fddbf7d
Aborted (core dumped)
error Command failed with exit code 134.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
spacesailor24
previously approved these changes
Jan 21, 2021
spacesailor24
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug from the latest metamask release.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.