Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types to work in both mocha and jasmine #64

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix types to work in both mocha and jasmine #64

merged 1 commit into from
Apr 28, 2020

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Apr 28, 2020

  1. Fix compatibility with jasmine
  2. Make sure types still works with mocha

@mgrybyk mgrybyk added the bug Something isn't working label Apr 28, 2020
@mgrybyk mgrybyk mentioned this pull request Apr 28, 2020
Merged
8 tasks
@codecov
Copy link

codecov bot commented Apr 28, 2020 •
edited
Loading

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   63.40%   63.40%           
=======================================
  Files          33       33           
  Lines         541      541           
  Branches      102      102           
=======================================
  Hits          343      343           
  Misses        188      188           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc39dc...e71949c. Read the comment docs.

christian-bromann
christian-bromann approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I wonder if we should have some compatibility tests in this repo. I will create an issue for it.

@christian-bromann christian-bromann merged commit a4f0355 into master Apr 28, 2020
@christian-bromann christian-bromann deleted the fix-jasmine-types branch April 28, 2020 17:27
@mgrybyk mgrybyk mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrybyk @christian-bromann