Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolving of scoped npm packages #447

Merged
merged 1 commit into from
May 9, 2017
Merged

fix: resolving of scoped npm packages #447

merged 1 commit into from
May 9, 2017

Conversation

roman-vanesyan
Copy link
Contributor

Fix #424

@jsf-clabot
Copy link

jsf-clabot commented May 3, 2017

CLA assistant check
All committers have signed the CLA.

@alexander-akait
Copy link
Member

@vanesyan thanks 👍

@joshwiens joshwiens changed the title Fix resolving of scoped npm packages fix: Resolving of scoped npm packages May 3, 2017
@roman-vanesyan
Copy link
Contributor Author

Any updates on the thread?

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanesyan Thx

@michael-ciniawsky michael-ciniawsky changed the title fix: Resolving of scoped npm packages fix: resolving of scoped npm packages May 5, 2017
@alexander-akait
Copy link
Member

/cc @jhnns friendly ping

@sirlancelot
Copy link

sirlancelot commented May 8, 2017

Any chance someone could get this merged? This is actually going to be a growing issue as more people start trying to bundle material-components-web which uses scoped packages extensively.

@michael-ciniawsky
Copy link
Member

@bebraw @d3viant0ne Does one of you have acces here? 😛 It's seems @jhnns is busy atm

@joshwiens
Copy link
Member

@sirlancelot - contrib was created to allow Tobias and other core member focus on Webpack. If you need to get a hold of someone, try the lead maintainer ( for repos like sass-loader that have one )

For other libs in webpack-contrib that are maintained by the organization or if you can't get in contact with the lead maintainer ( real life happens ) tag @webpack-contrib/org-maintainers or @d3viant0ne @bebraw.

If none of that works, DM me on gitter or twitter.

@joshwiens
Copy link
Member

@michael-ciniawsky - I'm working on that now, i'll get this sorted shortly.

@sirlancelot
Copy link

Thanks @d3viant0ne, I hadn't realized others were maintaining this. Thanks so much for you contributions!

@joshwiens joshwiens merged commit 8d37244 into webpack-contrib:master May 9, 2017
@roman-vanesyan
Copy link
Contributor Author

Can you also, please, upstream fix on npm?! :)

@merofeev
Copy link

merofeev commented May 9, 2017

Hello @d3viant0ne, @bebraw, @vanesyan!
This seems to be breaking recommended way to import custom Angular Material theme (see issue at Angular Material repo).

This worked fine with sass-loader 6.0.3
@import '~@angular/material/theming';
With sass-loader 6.0.4 this import leads to error:
File to import not found or unreadable: ~@angular/material/theming.

To make it work with sass-loader 6.0.4 I had to write
@import "~@angular/material/_theming.scss";

@roman-vanesyan
Copy link
Contributor Author

roman-vanesyan commented May 9, 2017

Yes, it seems that with landed pr sass-loader preventing from processing file formatting, (e.g. adding underscore and file extension on lines 42-47) Should be fixed...

@pselden
Copy link

pselden commented May 10, 2017

Also breaking my build for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants