Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: description for init command #2528

Merged
merged 2 commits into from
Mar 23, 2021
Merged

fix: description for init command #2528

merged 2 commits into from
Mar 23, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
fix description

Did you add tests for your changes?
No
If relevant, did you update the documentation?
Yes
Summary

initialize a new project

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner March 20, 2021 11:03
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few suggestions.

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@snitin315
Copy link
Member Author

I wonder why help tests for alias were passing all this time, pushing a fix now.

@alexander-akait
Copy link
Member

@snitin315 can you rebase?

@snitin315
Copy link
Member Author

@snitin315 can you rebase?

@alexander-akait Done 👍🏻

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2528 (a98af5a) into master (902a1db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2528   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          29       29           
  Lines        1458     1458           
  Branches      415      415           
=======================================
  Hits         1323     1323           
  Misses        135      135           
Impacted Files Coverage Δ
packages/generators/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902a1db...a98af5a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@alexander-akait
Copy link
Member

@snitin315 Can you rebase

@alexander-akait alexander-akait merged commit 0f0e403 into master Mar 23, 2021
@alexander-akait alexander-akait deleted the fix/init-des branch March 23, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants