Updated invalid devServer.proxy example code #2320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the last proxy example had an invalid config format. Tested with webpack 4.13.0 and webpack-dev-server 3.1.4.
EugeneHlushko
requested changes
Jul 2, 2018
There was a problem hiding this comment.
By looking at proxy schema i can tell that it looks like a bug that you found and need to file in webpack-dev-server repository, if an object isnt supported anymore they must change the validation.
|
Posted bug report for webpack-dev-server at webpack/webpack-dev-server#1438 |
|
Thank you @petterm lets wait and hear from them to decide on what steps to take with this PR (close or merge) |
|
As issue webpack/webpack-dev-server#1438 has been accepted as a bug report this pull request is no longer relevant. |
|
i just wanted to say THANK YOU for filing the bug report and creating this PR - i've spent over an hour trying to figure out why the example in the docs wasn't working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the last proxy example omitted the array format used in the example before it. Initial example did not work with webpack 4.13.0 and webpack-dev-server 3.1.4. The updated version worked fine.