Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct fetch: when cancelling due to redirect, read full body #688

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Sep 17, 2024

to avoid possible exception due to encoding. (Probably a node bug, reported in nodejs/undici#3616)
Replace abort with cancel, which is the recommended way to cancel the response.

fixes #687

@ikreymer ikreymer requested a review from tw4l September 17, 2024 04:13
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Nice to see that undici repo maintainers seem to be moving quickly on the node bug as well.

@ikreymer ikreymer merged commit 6b4ba5b into main Sep 17, 2024
4 checks passed
@ikreymer ikreymer deleted the fix-direct-fetch-redirect-cancel branch September 17, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brotli decompression error
2 participants