Close ZIP once finished #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is important to close the ZIP once data is finished being written to the WACZ or else some of the data may not be flushed to disk. This is probably more important for usage of py-wacz as a library since the file would automatically get flushed when it is used from the command line. Fixes webrecorder#20
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 81.10% 81.19% +0.08%
==========================================
Files 4 4
Lines 651 654 +3
Branches 128 144 +16
==========================================
+ Hits 528 531 +3
Misses 79 79
Partials 44 44
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thanks! I haven't been able to repro this yet, but if it fixes for you locally, that's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to close the ZIP once data is finished being written to
the WACZ or else some of the data may not be flushed to disk. This is
probably more important for usage of py-wacz as a library since the file
would automatically get flushed when it is used from the command line.
Fixes #20