Add support for omitting entire modules #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will enable entire modules to be conditionally omitted from test coverage measurement. Modules will be omitted using the coverage.py `[run] omit` configuration setting. https://coverage.readthedocs.io/en/stable/config.html#run-omit https://coverage.readthedocs.io/en/stable/source.html
sobolevn
approved these changes
Apr 22, 2023
|
Thanks for the prompt review @sobolevn! I'm happy to consider the nit you suggested, but it makes type annotations more complicated, and the It looks like we need to update |
|
What's missing here? |
|
I can work on it and finish it tomorrow. |
I didn't mean to give you work, I really wanted to know what was missing hahaha ...but thanks. |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
===========================================
- Coverage 90.90% 78.94% -11.97%
===========================================
Files 1 4 +3
Lines 11 19 +8
===========================================
+ Hits 10 15 +5
- Misses 1 4 +3
|
sobolevn
approved these changes
Jun 2, 2023
|
Thank you! Great idea! |
This was referenced Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will enable entire modules to be conditionally omitted from test coverage measurement (#2).
Changes
Modules will be omitted using the coverage.py
[run] omitconfiguration setting.The syntax for omitting modules will be slightly different from the suggestion by @sobolevn (#2 (comment)) to align more closely with the file pattern syntax used by coverage.py.
Related
[run] omit