Fix broken short rDNS names #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d86a31a. This change does not seem to be correct. See discussion: wez#66 (comment) The `12` was related to a fixed-size header and not related to the length of the variable-length rdns name. That length is encoded in the data part of the atom, in the call to `APar_atom_Binary_Put`.
Fixes wez#66. See extensive discussion there.
wilhuff
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d86a31a, restoring the initial allocation of the name atom to 12 bytes, which must be the case, given the way
AtomicLengthis treated. See #66 (comment) for why.Additionally, allocate the
AtomicDatabuffer to use a MAXDATA_PAYLOAD-sized buffer. This accommodates longer names that were causing problems in #44. Those crashes were happening because of heap corruption due to writing past the end of the 16-byte buffer.