-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FileSystemSyncAccessHandle async methods to sync #55
Conversation
Update FileSystemSyncAccessHandle methods all sync.
Change the return type to `undefined` from `void`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @annevk please feel free to merge this if it looks good to you. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging it's good practice to have all the checkboxes in OP checked, but also have the items actually completed and not as TBA. 😊 Could someone please file the remaining implementation bugs?
Co-authored-by: Anne van Kesteren <[email protected]>
Per discussions from #7 and #28, this PR updates FileSystemSyncAccessHandle getSize(), truncate(), flush() and close() asynchronous methods to synchronous.
Preview | Diff