Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileSystemSyncAccessHandle async methods to sync #55

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

dslee414
Copy link
Collaborator

@dslee414 dslee414 commented Sep 29, 2022

Per discussions from #7 and #28, this PR updates FileSystemSyncAccessHandle getSize(), truncate(), flush() and close() asynchronous methods to synchronous.


Preview | Diff

Update FileSystemSyncAccessHandle methods all sync.
Change the return type to `undefined` from `void`
Copy link
Collaborator

@a-sully a-sully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @annevk please feel free to merge this if it looks good to you. Thanks!

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging it's good practice to have all the checkboxes in OP checked, but also have the items actually completed and not as TBA. 😊 Could someone please file the remaining implementation bugs?

@a-sully
Copy link
Collaborator

a-sully commented Oct 26, 2022

Filed https://bugs.webkit.org/show_bug.cgi?id=247071 and https://bugzilla.mozilla.org/show_bug.cgi?id=1797579

Co-authored-by: Anne van Kesteren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants