Pass a request for user-initiated reload navigation #3586
Conversation
|
@domenic, can you take a look? This is a refactoring and I don't want to change the behavior. Thanks! |
|
I'm on vacation until April 1, but probably @annevk is a better reviewer for navigation anyway. |
| <span>active document</span>'s <span>reload override flag</span> is set, then the user agent may | ||
| instead perform <span>an overridden reload</span> rather than the navigation described in this | ||
| paragraph (with the <span>browsing context</span> being reloaded as the <span>source browsing | ||
| context</span>).</p> |
There was a problem hiding this comment.
This seems incorrect as it sets the request method to GET, whereas it could have been POST.
In general the layering here is very poor. We need to store the request method somewhere so that it can be reused in cases like this, but there's currently no explicit slot for that. Maybe a history entry is the right place.
I also think that in case you reload you probably just want to navigate to the current history entry in some way and not to a new request.
There was a problem hiding this comment.
Hmm, probably I read the current spec sentence wrongly.
The intention here is "whatever resource used for the navigation to the active document, reuse it", right?
There was a problem hiding this comment.
Yeah. Again, I agree it's a very sub par way of defining things.
|
Abandoning this PR... |
This is a preliminary change to fix w3c/ServiceWorker#1167. I'm
planning to merge "reload-triggered navigation" flag in the navigation algorithm and
"reload-navigation" flag which I'm going to introduce on request, and as a preparation
this change lets the user-initiated reload navigation give a request as resource.
/acknowledgements.html ( diff )
/history.html ( diff )