Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table border-color special case (which doesn't match reality) #4398

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Remove table border-color special case (which doesn't match reality) #4398

merged 2 commits into from
Mar 1, 2019

Conversation

dholbert
Copy link
Contributor

@dholbert dholbert commented Feb 27, 2019

@annevk
Copy link
Member

annevk commented Feb 28, 2019

@dholbert you'll need to accept the invite from https://github.com/mozilla-standards and make your membership of that organization public.

Implementations bugs are filed per #4391 and tests will land as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1530048.

It'd be nice if @davidsgrogan and @smfr could confirm they're okay with this.

@annevk
Copy link
Member

annevk commented Feb 28, 2019

@dholbert oh also, you should add yourself to the Acknowledgments section.

@dholbert
Copy link
Contributor Author

@dholbert you'll need to accept the invite from https://github.com/mozilla-standards and make your membership of that organization public.

Done.

@dholbert oh also, you should add yourself to the Acknowledgments section.

Sure -- done via a second commit on the same branch (so, looped into this pull request I think), in 0d463a0

@davidsgrogan
Copy link
Contributor

It'd be nice if @davidsgrogan and @smfr could confirm they're okay with this.

Looks good to me.

@annevk annevk merged commit 552ef78 into whatwg:master Mar 1, 2019
@annevk
Copy link
Member

annevk commented Mar 1, 2019

The rule after, thead, tbody, tfoot, tr { border-color: inherit; }, is still relevant due to the rule after that, right?

Thanks for all your work on this!

@dholbert
Copy link
Contributor Author

dholbert commented Mar 1, 2019

I believe it is theoretically relevant, yeah.

(I'm curious whether the rule after that is actually respected in browsers, too, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants