Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abstract operations instead of internal methods #161

Closed
domenic opened this issue Jul 24, 2014 · 1 comment
Closed

Use abstract operations instead of internal methods #161

domenic opened this issue Jul 24, 2014 · 1 comment
Labels
editorial Changes that do not affect how the standard is understood

Comments

@domenic
Copy link
Member

domenic commented Jul 24, 2014

Internal methods are misleading. It is better to restrict internal to "internal slots," i.e. things we need to store directly on the object, but privately.

We should follow the ES spec and use abstract operations instead.

Note that e.g. [[onCancel]] would remain in an internal slot, since it is a function we are storing. Whereas [[callOrScheduleAdvanceQueue]] would become an abstract operation.

This is a fairly easy, mechanical, and unimportant issue. Thus I will feel guilty if I work on it before getting through the more important stuff. If anyone else wants to give it a shot, patch welcome :).

@domenic
Copy link
Member Author

domenic commented Oct 6, 2014

Done as part of the Bikeshed conversion.

@domenic domenic closed this as completed Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes that do not affect how the standard is understood
Development

No branches or pull requests

1 participant