Apply the emphasis and code mark up separately #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I would in general prefer to use the ES-spec style throughout, including #161. In the end there should actually be very little |
| @@ -159,14 +159,14 @@ For now, please consider the reference implementation normative: [reference-impl | |||
| 1. If `this.[[state]]` is `"errored"` or `"closed"`, return **false**. | |||
| 1. Let _chunkSize_ be Invoke(`this.[[strategy]]`, `"size"`, (_chunk_)). | |||
| 1. If _chunkSize_ is an abrupt completion, | |||
| 1. Call `this.[[error]](_chunkSize_.[[value]])`. | |||
| 1. Call `this.[[error]]`(_chunkSize_.`[[value]]`). | |||
There was a problem hiding this comment.
So the ES spec would not code-ize [[value]], i.e. it would be chunkSize.[[value]] not chunkSize.[[value]]
|
I can help, but yes if we make lots of lint changes, it'll be difficult to merge ongoing branches. So, I just follow the style for new code for now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Domenic,
I'd like to hear your opinion about styling. Do you have any preference on mark up on arguments and the callable in "call something" algorithm? Maybe we want to use something close to one used by es specification?