Fill the internal slots section of ReadableByteStreamController #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. It's ideal to get the RS/RBS merge issue done first, but the RBS spec has been TBA for too long time. |
| <td>An object representation of the stream's underlying byte source | ||
| </tr> | ||
| <tr> | ||
| <td>\[[pullAgain]] |
There was a problem hiding this comment.
Can you use the descriptions from ReadableStream for pullAgain and pulling? They are still accurate, right? Or if they mean something different here, could you explain it in a bit more detail like they do?
There was a problem hiding this comment.
Got it! Regarding pulling, I made a small change (removing fulfill) since the current pull operation of the readable byte stream doesn't use a promise.
|
Addressed comments: New commit: 97e0c97 |
domenic
force-pushed
the
internalslotsofcontroller
branch
from
97e0c97 to
42cbdc7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.