Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync spec and implementation of autoAllocateChunkSize #592

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

isonmad
Copy link
Contributor

@isonmad isonmad commented Nov 3, 2016

autoAllocateChunkSize was added in #430 as commit e601d69.

The spec was out of sync with the reference implementation: it tried to round
non-integers into integers instead of rejecting them.

The reference implementation was out of sync with the spec: it was allowing
an autoAllocateChunkSize of 0 through instead of throwing a RangeError.

autoAllocateChunkSize was added in whatwg#430 as commit e601d69.

The spec was out of sync with the reference implementation: it tried to round
non-integers into integers instead of rejecting them.

The reference implementation was out of sync with the spec: it was allowing
an autoAllocateChunkSize of 0 through instead of throwing a RangeError.
@domenic
Copy link
Member

domenic commented Nov 3, 2016

Great catch, thank you.

@domenic domenic merged commit 20d738f into whatwg:master Nov 3, 2016
isonmad pushed a commit to isonmad/streams that referenced this pull request Nov 4, 2016
@isonmad isonmad mentioned this pull request Nov 4, 2016
domenic pushed a commit that referenced this pull request Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants