Fix URI::RFC2396_PARSER issue with older Rubies #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to URI::RFC2396_PARSER in 028fd33 resulted in problems with older versions of Ruby where URI::RFC2396_PARSER is not defined. Although URI::RFC2396_PARSER was added and backported to the vendored uri library in older versions of Ruby, we check for URI::RFC2396_PARSER's presence such that the warnings are avoided when using a newer non-vendored version of the gem.
|
Thanks much! |
|
Huh, why did the CI not run on the pull request?.. I'm confused. |
|
In any case, released as 1.10.1, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to URI::RFC2396_PARSER in 028fd33 resulted in problems with older versions of Ruby where URI::RFC2396_PARSER is not defined. Although URI::RFC2396_PARSER was added and backported to the vendored uri library in older versions of Ruby, we check for URI::RFC2396_PARSER's presence such that the warnings are avoided when using a newer non-vendored version of the gem. See ruby/uri#118.