Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_widget can fail #14

Closed
maartenbreddels opened this issue May 13, 2023 · 0 comments
Closed

get_widget can fail #14

maartenbreddels opened this issue May 13, 2023 · 0 comments

Comments

@maartenbreddels
Copy link
Contributor

see widgetti/solara#81
This was referenced Sep 13, 2023
Merged
Open
@iisakkirotko iisakkirotko mentioned this issue Sep 25, 2023
Open
maartenbreddels added a commit that referenced this issue Oct 3, 2023
@maartenbreddels
fix: get_widget did not always work for function components
4457b9c 
We only searched through the current context, which made it work
when all parents are widget components (which do not create a new
context).
Now we search through all child contexts, which makes it work for
function components as well.

Fixes #14
maartenbreddels added a commit that referenced this issue Oct 3, 2023
@maartenbreddels
fix: get_widget did not always work for function components
ba52c3a 
We only searched through the current context, which made it work
when all parents are widget components (which do not create a new
context).
Now we search through all child contexts, which makes it work for
function components as well.

Fixes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maartenbreddels