[fix] Fix streams not draining properly #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indexzero
approved these changes
Apr 25, 2018
This was referenced Apr 25, 2018
DABH
pushed a commit
to DABH/winston
that referenced
this pull request
Apr 26, 2018
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #1144. It seems like the
_streamis not draining properly, but by draining the_deststream we also drain the_streambecause they are piped together? I'm not sure about this, because it did fix the script provided by @juanda99. This doesn't fix the script of @kramer65, possible because thewhile (true) { }loop is blocking the NodeJS event-loop.