Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Link Retriever #3

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Fix: Link Retriever #3

merged 3 commits into from
Oct 10, 2022

Conversation

seangwright
Copy link
Contributor

@seangwright seangwright commented Oct 10, 2022 •
edited
Loading

  • Register Link Retriever as Transient instead of Singleton so it can accept transient/scoped dependencies
  • Plumb CancellationToken as optional method param for link data retriever
  • Docs
    • Add required using statements to code examples
    • Update project name to Xperience Page Links
  • Add missing project metadata to XperienceCommunity.LinkablePages project
  • Bump project version to 3.0.0

@seangwright seangwright self-assigned this Oct 10, 2022
@seangwright seangwright merged commit a9a0e69 into main Oct 10, 2022
@seangwright seangwright deleted the fix/page-link-retriever branch October 10, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seangwright seangwright

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seangwright