test: add column-queries data loss tests

withastro · Mar 12, 2024 · 35761b2 · 35761b2
1 parent f9811da
commit 35761b2
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 2 deletions.
diff --git a/packages/db/src/core/cli/migration-queries.ts b/packages/db/src/core/cli/migration-queries.ts
@@ -7,7 +7,6 @@ import { hasPrimaryKey } from '../../runtime/index.js';
 import {
 	getCreateIndexQueries,
 	getCreateTableQuery,
-	getDropTableIfExistsQuery,
 	getModifiers,
 	getReferencesConfig,
 	hasDefault,
@@ -76,7 +75,7 @@ export async function getMigrationQueries({
 		const addedColumns = getAdded(oldCollection.columns, newCollection.columns);
 		const droppedColumns = getDropped(oldCollection.columns, newCollection.columns);
 		const notDeprecatedDroppedColumns = Object.fromEntries(
-			Object.entries(droppedColumns).filter(([key, col]) => !col.schema.deprecated)
+			Object.entries(droppedColumns).filter(([, col]) => !col.schema.deprecated)
 		);
 		if (!isEmpty(addedColumns) && !isEmpty(notDeprecatedDroppedColumns)) {
 			throw new Error(

diff --git a/packages/db/test/unit/column-queries.test.js b/packages/db/test/unit/column-queries.test.js
@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import { describe, it } from 'mocha';
+import * as color from 'kleur/colors';
 import {
 	getCollectionChangeQueries,
 	getMigrationQueries,
@@ -106,6 +107,76 @@ describe('column queries', () => {
 			expect(queries).to.deep.equal([]);
 		});
 
+		it('should return warning if column type change introduces data loss', async () => {
+			const blogInitial = tableSchema.parse({
+				...userInitial,
+				columns: {
+					date: column.text(),
+				},
+			});
+			const blogFinal = tableSchema.parse({
+				...userInitial,
+				columns: {
+					date: column.date(),
+				},
+			});
+			const { queries, confirmations } = await userChangeQueries(blogInitial, blogFinal);
+			expect(queries).to.deep.equal([
+				'DROP TABLE "Users"',
+				'CREATE TABLE "Users" (_id INTEGER PRIMARY KEY, "date" text NOT NULL)',
+			]);
+			expect(confirmations).to.deep.equal([
+				`Updating existing column ${color.bold(
+					`${TABLE_NAME}.date`
+				)} to a new type that cannot be handled automatically.`,
+			]);
+		});
+
+		it('should return warning if new required column added', async () => {
+			const blogInitial = tableSchema.parse({
+				...userInitial,
+				columns: {},
+			});
+			const blogFinal = tableSchema.parse({
+				...userInitial,
+				columns: {
+					date: column.date({ optional: false }),
+				},
+			});
+			const { queries, confirmations } = await userChangeQueries(blogInitial, blogFinal);
+			expect(queries).to.deep.equal([
+				'DROP TABLE "Users"',
+				'CREATE TABLE "Users" (_id INTEGER PRIMARY KEY, "date" text NOT NULL)',
+			]);
+			expect(confirmations).to.deep.equal([
+				`You added new required column '${color.bold(
+					`${TABLE_NAME}.date`
+				)}' with no default value.` + '\n      This cannot be executed on an existing table.',
+			]);
+		});
+
+		it('should return warning if non-number primary key with no default added', async () => {
+			const blogInitial = tableSchema.parse({
+				...userInitial,
+				columns: {},
+			});
+			const blogFinal = tableSchema.parse({
+				...userInitial,
+				columns: {
+					id: column.text({ primaryKey: true }),
+				},
+			});
+			const { queries, confirmations } = await userChangeQueries(blogInitial, blogFinal);
+			expect(queries).to.deep.equal([
+				'DROP TABLE "Users"',
+				'CREATE TABLE "Users" ("id" text PRIMARY KEY)',
+			]);
+			expect(confirmations).to.deep.equal([
+				`You added new required column '${color.bold(`${TABLE_NAME}.id`)}' with no default value.` +
+					'\n      This cannot be executed on an existing table.',
+			]);
+		});
+
 		it('should be empty when type updated to same underlying SQL type', async () => {
 			const blogInitial = tableSchema.parse({
 				...userInitial,