fix(rendering): prevent removal of necessary <astro-slot> elements

withastro · Mar 4, 2024 · e713ce0 · e713ce0
1 parent d1700cf
commit e713ce0
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/packages/astro/src/runtime/server/render/component.ts b/packages/astro/src/runtime/server/render/component.ts
@@ -65,13 +65,6 @@ function isHTMLComponent(Component: unknown) {
 	return Component && (Component as any)['astro:html'] === true;
 }
 
-const ASTRO_SLOT_EXP = /<\/?astro-slot\b[^>]*>/g;
-const ASTRO_STATIC_SLOT_EXP = /<\/?astro-static-slot\b[^>]*>/g;
-function removeStaticAstroSlot(html: string, supportsAstroStaticSlot: boolean) {
-	const exp = supportsAstroStaticSlot ? ASTRO_STATIC_SLOT_EXP : ASTRO_SLOT_EXP;
-	return html.replace(exp, '');
-}
-
 async function renderFrameworkComponent(
 	result: SSRResult,
 	displayName: string,
@@ -309,9 +302,7 @@ If you're still stuck, please open an issue on GitHub or join us at https://astr
 					destination.write(html);
 				} else if (html && html.length > 0) {
 					destination.write(
-						markHTMLString(
-							removeStaticAstroSlot(html, renderer?.ssr?.supportsAstroStaticSlot ?? false)
-						)
+						markHTMLString(html)
 					);
 				}
 			},
@@ -391,7 +382,9 @@ If you're still stuck, please open an issue on GitHub or join us at https://astr
 					})
 				);
 			}
-			destination.write(markHTMLString(renderElement('astro-island', island, false)));
+			const element = markHTMLString(renderElement('astro-island', island, false));
+			debugger;
+			destination.write(element);
 		},
 	};
 }