-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cli package resolution for @astrojs/db
#10338
Conversation
|
This was mentioned in Discord (as a reply to a triage/PR message for this issue):
Not sure if this relates to this issue or another one, maybe the fix for this is more complicated? I will close this if I hear anything else about the issue being fixed |
That is being fixed at #10342. It looks like this is a bit different than that though. I was waiting for someone more familiar with db before merging this, just in case, but seems like this is a simple fix enough. EDIT: nvm Matthew just approved. |
Now that this has been approved, is this waiting on me to merge it? Sorry I haven't made a PR in a long time and I just want to make sure I am not blocking this |
You can merge but no I didn't expect that and it wasn't blocking the PR. I saw Matthew approved and I thought he was gonna merge it. I'm gonna merge this now 😄 |
Awesome thanks! |
Changes
Fixes bug where every time a
astro db
command is used it prompts the user to add@astrojs/db
even if it is already installedTesting
No tests, it is a pretty small fix for an error that doesn't get surfaced because it is inside a try/catch
Docs
No docs needed