Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: scaffold db files when using astro add db #10349

Merged
merged 6 commits into from
Mar 7, 2024
Merged

db: scaffold db files when using astro add db #10349

merged 6 commits into from
Mar 7, 2024

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 6, 2024

Changes

  • (Sorta) blocked by Add /db/* redirects astro.build#1000
  • Updates astro add CLI to scaffold out the db/ directory
  • Refactors the stub logic in astro add for improved maintainability
  • We'll eventually want to expose scaffolding functionality for any integration, but that will take some API design work. Right now, we just need to improve the astro add db experience. Baby steps!
  • Bonus: removes default logger formatting when running any astro add command (AS INTENDED!)
  • Closes PLT-1764

Testing

Tested manually because astro add isn't tested

Docs

Will be documented in preparation for launch day

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 9cd3e86

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 6, 2024
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are DaBest 👏

@natemoo-re natemoo-re merged commit 7001ae4 into main Mar 7, 2024
4 checks passed
@natemoo-re natemoo-re deleted the add-db branch March 7, 2024 19:50
This was referenced Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants