fix(rewrite): allow to rewrite 404 and take base into consideration
#11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f501042 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
ematipico
force-pushed
the
fix/rewriting-bugs
branch
from
7b79492 to
9bfcecf
Compare
matthewp
reviewed
Jun 17, 2024
Co-authored-by: Florian Lefebvre <[email protected]>
matthewp
approved these changes
Jun 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11235
This PR fixes few bugs and reverts some changes:
404(again). I believe it makes sense to rewrite/404even in SSGtrailingSlashis"never"and the user usesAstro.rewrite("/")tryRewriteand moved inside a generic function, since there was shared logicTesting
I created new test cases with custom
404.astroand default 404.I created new test cases with
trailingSlash: "never"Docs
N/A