fix(rewrite): correctly update the status code during a rewrite #11352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d97cdbf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Jul 1, 2024
Merged
ematipico
added a commit
that referenced
this pull request
Jul 18, 2024
* fix(rewrite): correctly update the status code during a rewrite * rebase * remove `.only` * remove log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11306
The issue was caused by
this.statusinside theRenderContextclass. This status code is then passed to theSSResultand used as initial status ofResponse.This status code was passed by
route.ts. It was a 404 because/foodidn't match any route, however we still call the middleware because the user choserouting: 'manual'.When we arrived to the middleware, we executed the rewrite, and we need update this status code in case we find a
RouteDataand aComponentInstance.I moved the shared logic inside a new, private, function called
#executeRewriteas per @florian-lefebvre suggestion.Testing
Added a new test case
Docs
N/A