-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclaimer for Github pages / jekyll quirk #1355
Conversation
🦋 Changeset detectedLatest commit: 0d2c9e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). astro-docs – ./docs🔍 Inspect: https://vercel.com/pikapkg/astro-docs/GheSg7aQxs5zNrfdWgJZXenwbCpE astro-www – ./www🔍 Inspect: https://vercel.com/pikapkg/astro-www/5gpHUzp68MWbt9foDayi5E7GYDqD |
_astro
folder by default, added warning+fix
Reworded the disclaimer, I think the narrow docs size is throwing off my "text quality" detector for some reason 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just nit change to write GitHub Pages
with correct letter casing
Did a small rewrite but overall LGTM! |
Changes
References:
https://discord.com/channels/830184174198718474/887002135403827240/ (help thread where this came up)
mpetrovich/stylemark#65 (another issue with the fix)
Testing
No testing, only docs changed.
Docs
Documentation updated