Fix types for TableHTMLAttributes #6197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'string' type to 'border' attribute - Add 'false | true' to 'frame' attribute Thanks Princesseuh for helping
🦋 Changeset detectedLatest commit: a56cba5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
reviewed
Feb 9, 2023
|
I updated the changeset but I am not sure if it is descriptive enough I could change Or maybe change it to this?
Sorry I have never written a changeset before |
natemoo-re
approved these changes
Feb 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringtype toborderattribute forTableHTMLAttributes'false' | 'true'types toframeattribute forTableHTMLAttributesThanks @Princesseuh for helping
Changes
What does this change?
Fix types for TableHTMLAttributes
Testing
I am not sure if this needs testing
Docs
I don't think this adds or changes any docs