Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dev CLI flow #7809

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Refactor dev CLI flow #7809

merged 2 commits into from
Jul 26, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 26, 2023

Changes

Note: this merges into the js-api branch

Refactor the dev command CLI flow

  1. Remove openConfig usage, switch to resolveConfig instead
  2. Make a somewhat cleaner dev() JS API (now accepts AstroInlineConfig)
  3. Update tests with new signature.

Next will be making the same changes as no2 for all other commands, which should be easier than dev.

Testing

Existing tests should pass. I also tested the dev command locally, especially restarts when editing astro.config.mjs.

Docs

n/a. internal change for now. will document more when we expose a JS API.

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 25cc7d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 26, 2023
ematipico

This comment was marked as outdated.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better now!

@bluwy bluwy merged commit d773dd4 into js-api Jul 26, 2023
@bluwy bluwy deleted the dev-cli branch July 26, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants